Expand the search space for shapes in from.operation
#571
Conversation
So currenly, when you define a `from` `operation` `path` in generator.yaml fieldConfig, the code-generator checks for the read_only configuration to decide whether to get the field from the input shape or the output shape. The change introduced here tries to retrieve spec fields from input shapes first, if not found it checks output shape. If read_only is configured to true, it does so in reverse order (checks output shape first, if not found, checks input shape)
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Nice/test ec2-controller-test |
a-hilaly
changed the title
from operation to take output shapesfrom.operation
Description of changes:
So currently, when you define a
fromoperationpathin generator.yaml fieldConfig, the code-generator checks for
the read_only configuration to decide whether to get the field
from the input shape or the output shape.
The change introduced here tries to retrieve spec fields from input
shapes first, if not found it checks output shape.
If read_only is configured to true, it does so in reverse order
(checks output shape first, if not found, checks input shape)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.