fix: ensuring secret generation is accurate #578
Conversation
When generating SetSDK, we were passing the memberName to check if a field is a secret. When the secret field is nested, we need to pass memberFieldPath. That is what this change accomplishing
|
/retest |
|
/lgtm cancel |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test eks-controller-test |
Description of changes:
When generating SetSDK, we were passing the memberName
to check if a field is a secret. When the secret field is nested,
we need to pass memberFieldPath. That is what this change
accomplishing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.