Skip to content

User Agent String is not being populated correctly #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brycahta opened this issue Feb 9, 2022 · 1 comment
Closed

User Agent String is not being populated correctly #1171

brycahta opened this issue Feb 9, 2022 · 1 comment
Assignees
@jaypipes
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
ACK Core (2021-03...

Comments

@brycahta
Copy link
Contributor

brycahta commented Feb 9, 2022 •
edited by RedbackThomson
Loading

Describe the bug
When querying EC2-controller usage data, the user-agent string returns:
aws-controller-k8s/- (GitCommit/; BuildDate/; CRDKind/; CRDVersion/) aws-sdk-go/1.37.10 (go1.17.5; linux; amd64)

Steps to reproduce

  • Query aws-controller-k8s user-agent string in metrics/dashboard (I am using internal service).

Expected outcome
I expect $SERVICE-controller to be denoted somewhere and GitCommit, BuildDate, CRDKind, and CRDVersion to be populated. Also, (from Jay), the string should read aws-controllers-k8s (with an 'S')

Environment

  • Kubernetes version N/A
  • Using EKS (yes/no), if so version? N/A
  • AWS service targeted (S3, RDS, etc.) EC2, but applies to all
@brycahta brycahta added the kind/bug Categorizes issue or PR as related to a bug. label Feb 9, 2022
@vijtrip2 vijtrip2 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 9, 2022
@jaypipes jaypipes self-assigned this Feb 9, 2022
@RedbackThomson
Copy link
Contributor

Probably this little guy: https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/cmd/controller/main.go.tpl#L90

@RedbackThomson RedbackThomson added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 10, 2022
jaypipes added a commit to jaypipes/ack-code-generator that referenced this issue Apr 6, 2022
@jaypipes
add real versions to controller main.go
9ae3091 
I'd left a TODO in the main.go template for controllers to fill in their
GitVersion, GitCommit and BuildDate information properly. Just now
getting around to this...

Issue: aws-controllers-k8s/community#1171

Signed-off-by: Jay Pipes <[email protected]>
@jaypipes jaypipes mentioned this issue Apr 6, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this issue Apr 6, 2022
@jaypipes
add real versions to controller main.go (#321)
9191f9d 
I'd left a TODO in the main.go template for controllers to fill in their
GitVersion, GitCommit and BuildDate information properly. Just now
getting around to this...

Issue: aws-controllers-k8s/community#1171

Signed-off-by: Jay Pipes <[email protected]>

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaypipes jaypipes

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
ACK Core (2021-03-14 thru 2022-03-25)
Development

No branches or pull requests
5 participants
@jaypipes @RedbackThomson @a-hilaly @brycahta @vijtrip2