Skip to content

Implement update functionality for VPCEndpoint resource #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brycahta opened this issue Mar 2, 2022 · 17 comments
Open

Implement update functionality for VPCEndpoint resource #1205

brycahta opened this issue Mar 2, 2022 · 17 comments
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. service/ec2 Indicates issues or PRs that are related to ec2-controller.

Comments

@brycahta
Copy link
Contributor

brycahta commented Mar 2, 2022

Is your feature request related to a problem?
ec2-controller supports Create/Delete functionality for VPCEndpoint resource, but not Update.

Describe the solution you'd like
I should be able to modify/update an ACK-managed VPCEndpoint resource using its controller

Describe alternatives you've considered
Updating resource myself using aws-sdk, cli, or console
@brycahta brycahta added the kind/enhancement Categorizes issue or PR as related to existing feature enhancements. label Mar 2, 2022
@brycahta
Copy link
Contributor Author

ModifyVpcEndpoint is an ignored operation in generator.yaml.

Note, resource will not be in ACK.ResourceSynced condition if users do not provide a policyDocument in the Spec because AWS will set a default policyDocument if not provided. The resulting diff will trigger update (not implemented)

@jaypipes
Copy link
Collaborator

@brycahta sounds like policyDocument should be lateInitiailized?

@brycahta brycahta mentioned this issue Mar 30, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/ec2-controller that referenced this issue Mar 30, 2022
@brycahta
late init VPCEndpoint.PolicyDocument field (#47)
67545f7 
Issue #, if available: aws-controllers-k8s/community#1205

Description of changes:
* Late initializes `PolicyDocument` field so VPCEndpoint can achieve Synced state if `PolicyDocument` is not provided in the Spec. This is necessary because the API [defaults PolicyDocument](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVpcEndpoint.html), if not provided.
* Updates related test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 22, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-bot ack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 22, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-bot ack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 22, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 21, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

@ack-bot ack-bot closed this as completed Aug 21, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 21, 2022

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot ack-bot moved this to Done in EC2 GA Roadmap Aug 21, 2022
@a-hilaly
Copy link
Member

/reopen

@ack-bot ack-bot reopened this Aug 21, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 21, 2022

@a-hilaly: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly a-hilaly removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 21, 2022
@brycahta brycahta moved this from Done to Todo in EC2 GA Roadmap Aug 30, 2022
@brycahta
Copy link
Contributor Author

brycahta commented Sep 6, 2022

/reopen

image

@eks-bot
Copy link

eks-bot commented Dec 5, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-bot ack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2022
@a-hilaly a-hilaly added service/ec2 Indicates issues or PRs that are related to ec2-controller. and removed EC2 labels Dec 13, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 12, 2023

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-bot ack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 12, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented Feb 12, 2023

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

@ack-prow ack-prow bot closed this as completed Feb 12, 2023
@ack-prow
Copy link

ack-prow bot commented Feb 12, 2023

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in EC2 GA Roadmap Feb 12, 2023
@a-hilaly a-hilaly reopened this Feb 13, 2023
@a-hilaly a-hilaly removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 13, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented May 14, 2023

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 14, 2023
@RedbackThomson
Copy link
Contributor

/lifecycle frozen

@ack-prow ack-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 16, 2023
@cannonpalms
Copy link

Do we know what the comment in the unimplemented sdkUpdate(...) fn refers to?

	// TODO(jaypipes): Figure this out...

Is there something tricky here to be figured out? If so, what is the context?

@a-hilaly
Copy link
Member

a-hilaly commented Jun 4, 2024

@cannonpalms I was going to reply "that is the generated code when update operations are too complex to handle", but looks like it's that AND we probably have a code-generator bug https://github.com/aws-controllers-k8s/code-generator/blob/14cef51778d471698018b6c38b604181a6948248/templates/pkg/resource/sdk_update_not_implemented.go.tpl#L1-L10

@a-hilaly a-hilaly added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. service/ec2 Indicates issues or PRs that are related to ec2-controller.
Projects
No open projects
EC2 GA Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jaypipes @RedbackThomson @cannonpalms @a-hilaly @eks-bot @brycahta @ack-bot