Support attachment of InternetGateway to VPC
#1216
Assignees
Labels
kind/enhancement
Categorizes issue or PR as related to existing feature enhancements.
Comments
RedbackThomson
added
kind/enhancement
ack-bot
pushed a commit
to aws-controllers-k8s/ec2-controller
that referenced
this issue
Mar 31, 2022
Closes aws-controllers-k8s/community#1216 Description of changes: Add support for attaching an `InternetGateway` to a `VPC`. The EC2 API exposes a list of `Attachments` when you describe `InternetGateway`, but manual testing shows that you can only attach a gateway to a single VPC - so this is treated as a list of at most one element. I had to create a new VPC for integration tests, since the default VPC we use for all of the other tests already contains an IGW, and you can have at most 1 per VPC. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
The EC2 controller currently supports creating an
InternetGatewayresource, but does not support theInternetGatewayAttachmentwhich means you can't mount it to aVPCwithout doing so manually.InternetGatewayAttachmentdoes not warrant its own resource, since it does not have an identifier of its own. It would be more appropriate to put a new field for VPCID on theInternetGatewayspec.Describe the solution you'd like
The text was updated successfully, but these errors were encountered: