[Elasticache] when using redis >=6, the controller still compares the patch version

[Julian-Chu]

Describe the bug
when I set engineVersion: 6.2 in the manifest, the controller always logs the engineVersion is diff because of patch version.

2023-03-20T12:48:56.000Z	INFO	ackrt	desired resource state has changed	{"account": "647927084307", "role": "", "region": "eu-west-1", "kind": "ReplicationGroup", "namespace": "cloud-application-platform", "name": "oamapp-0083-version-test", "is_adopted": false, "generation": 2, "diff": [{"Path":{"Parts":["Spec","EngineVersion"]},"A":"6.2","B":"6.2.6"}]}

based on elasticache doc, the patch version is managed by AWS when redis >=6:

Beginning with Redis 6.0, ElastiCache for Redis will offer a single version for each Redis OSS minor release, rather than offering multiple patch versions.

This issue also prevents the sequent modification like description change.

Steps to reproduce
apply the following yaml, and log the elasticache controller

apiVersion: elasticache.services.k8s.aws/v1alpha1
kind: ReplicationGroup
metadata:
  name: oamapp-0083-version-test
spec:
    cacheNodeType: cache.t3.micro
    cacheParameterGroupName: default.redis6.x
    cacheSubnetGroupName: default
    description: version test
    engine: redis
    engineVersion: "6.2"
    numNodeGroups: 1
    replicationGroupID: oamapp-0083-version-test
    replicasPerNodeGroup: 0
    transitEncryptionEnabled: true
    tags:
      - key: test
        value: "test"

Expected outcome
if set minor version explicitly like 7.0 or 6.2, controller should skip the patch version

source code

Environment

• Kubernetes version: 1.23
• Using EKS: 1.23
• AWS service targeted: elasticache controller v0.0.22

[jaypipes]

Hmm, this is another one of ElastiCache's server-side override fields. Similar to the User AccessString, ElastiCache will override the value of this field in certain cases from what the user provided in the desired field value.

We have another issue that is tracking this problem though you can see we've made no progress on this in 18 months. We should be able to use a custom comparison code block to handle these cases individually for now, but long term I'd like to persue issue #855 as the eventual code-generated solution.

[Julian-Chu]

Thanks @jaypipes , my team will submit the custom comparison for short term 😄

[Julian-Chu]

/assign @joaquinservetto

[ack-prow]

@Julian-Chu: GitHub didn't allow me to assign the following users: joaquinservetto.

Note that only aws-controllers-k8s members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @joaquinservetto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[Julian-Chu]

fixed by aws-controllers-k8s/elasticache-controller#115