EC2 Controller: API errors with VPC when not including optional fields enableDNSHostnames and enableDNSSupport

[aaroniscode]

Describe the bug
When creating a VPC and not including optional fields enableDNSHostnames and enableDNSSupport, the controller creates the VPC but then outputs API errors in the logs.

Steps to reproduce
Create a VPC custom resource

apiVersion: ec2.services.k8s.aws/v1alpha1
kind: VPC
metadata:
  name: test
  namespace: default
spec:
  cidrBlocks:
  - 10.0.0.0/16
  tags:
  - key: Name
    value: test

Logs show:

2023-06-14T19:43:03.578Z	INFO	ackrt	desired resource state has changed	{"account": "123456789012", "role": "", "region": "us-west-2", "kind": "VPC", "namespace": "default", "name": "test", "is_adopted": false, "generation": 2, "diff": [{"Path":{"Parts":["Spec","EnableDNSHostnames"]},"A":null,"B":false},{"Path":{"Parts":["Spec","EnableDNSSupport"]},"A":null,"B":true}]}
2023-06-14T19:43:03.733Z	ERROR	Reconciler error	{"controller": "vpc", "controllerGroup": "ec2.services.k8s.aws", "controllerKind": "VPC", "VPC": {"name":"test","namespace":"default"}, "namespace": "default", "name": "test", "reconcileID": "815db277-7e7f-46c0-9928-987d83e84a6b", "error": "InvalidParameterCombination: No attributes specified.\n\tstatus code: 400, request id: 051a766d-bd9a-4566-ab45-3d802f79d987"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235

Expected outcome
No errors in logs.

Environment

• Kubernetes version: EKS 1.27
• Using EKS (yes/no), if so version? yes, 1.27
• AWS service targeted (S3, RDS, etc.) EC2 controller v1.0.3

[RedbackThomson]

Do you see this error echoed in the status of the VPC object?

[aaroniscode]

yes

» kubectl get vpc -o yaml
apiVersion: v1
items:
- apiVersion: ec2.services.k8s.aws/v1alpha1
  kind: VPC
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"ec2.services.k8s.aws/v1alpha1","kind":"VPC","metadata":{"annotations":{},"name":"test","namespace":"default"},"spec":{"cidrBlocks":["10.0.0.0/16"],"tags":[{"key":"Name","value":"test"}]}}
    creationTimestamp: "2023-06-16T15:45:36Z"
    finalizers:
    - finalizers.ec2.services.k8s.aws/VPC
    generation: 2
    name: test
    namespace: default
    resourceVersion: "412888"
    uid: 5eed331b-2aa7-4aa2-b9f9-2f5b1f422b05
  spec:
    cidrBlocks:
    - 10.0.0.0/16
    instanceTenancy: default
    tags:
    - key: Name
      value: test
  status:
    ackResourceMetadata:
      ownerAccountID: "123456789012"
      region: us-west-2
    cidrBlockAssociationSet:
    - associationID: vpc-cidr-assoc-090eaa19a20cb981d
      cidrBlock: 10.0.0.0/16
      cidrBlockState:
        state: associated
    conditions:
    - message: "InvalidParameterCombination: No attributes specified.\n\tstatus code:
        400, request id: 9cd67fa1-d85c-47fd-a3d2-b1ef9d79370f"
      status: "True"
      type: ACK.Recoverable
    - lastTransitionTime: "2023-06-16T15:45:41Z"
      message: Unable to determine if desired resource state matches latest observed
        state
      reason: "InvalidParameterCombination: No attributes specified.\n\tstatus code:
        400, request id: 9cd67fa1-d85c-47fd-a3d2-b1ef9d79370f"
      status: Unknown
      type: ACK.ResourceSynced
    dhcpOptionsID: dopt-953d41ed
    isDefault: false
    ownerID: "123456789012"
    state: available
    vpcID: vpc-0c209ff8cc5ae412c
kind: List
metadata:
  resourceVersion: ""

[LikithaVemulapalli]

Hello, considering only the existing functionality and how it works, both the optional fields enableDNSHostnames and enableDNSSupport are of type bool, and the only valid values are either true or false for these fields in order to avoid the above mentioned errors.