Skip to content

[SecurityGroups] Add support for securityGroupRef and vpcRef settings inside the userIDGroupPairs #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adriananeci opened this issue Apr 22, 2024 · 2 comments
Closed

[SecurityGroups] Add support for securityGroupRef and vpcRef settings inside the userIDGroupPairs #2059

adriananeci opened this issue Apr 22, 2024 · 2 comments
Assignees
@a-hilaly
Labels
kind/feature Categorizes issue or PR as related to a new feature. service/ec2 Indicates issues or PRs that are related to ec2-controller.

Comments

@adriananeci
Copy link

Is your feature request related to a problem?

Add support for securityGroupRef and vpcRef settings inside the userIDGroupPairs of a SecurityGroup object

Describe the solution you'd like

We are creating/grouping multiple SecurityGroups ACK objects into a single helm chart, along with other ACK objects (VPC, Subnets, etc). Some of these SGs need to be referenced in other SGs that are part of the same chart. Based on https://aws-controllers-k8s.github.io/community/reference/ec2/v1alpha1/securitygroup/ there are few options via userIDGroupPairs when a SG needs to be referenced in another SG: groupID or groupName. Given the SG ID is not known beforehand the only option left in this case is groupName. But in order to use the groupName option we'll also need to pass the VPC ID is again is not know beforehand since the VPC object creation is part of the same helm chart.

Describe alternatives you've considered

#2058
@a-hilaly a-hilaly mentioned this issue Apr 22, 2024
Merged
@a-hilaly a-hilaly added service/ec2 Indicates issues or PRs that are related to ec2-controller. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 22, 2024
@a-hilaly a-hilaly self-assigned this Apr 22, 2024
@a-hilaly
Copy link
Member

@adriananeci thank you for reporting this! Shipping a release soon :)

ack-prow bot pushed a commit to aws-controllers-k8s/ec2-controller that referenced this issue Apr 22, 2024
@a-hilaly
Add VPC and SecurityGroup references for UserIDGroupPair type (#…
cd75ad9 
…187)

Addresses: aws-controllers-k8s/community#2059

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@adriananeci
Copy link
Author

Closing as aws-controllers-k8s/ec2-controller#187 was released

nnbu pushed a commit to nnbu/ack-ec2-controller that referenced this issue Sep 18, 2024
@a-hilaly
Add VPC and SecurityGroup references for UserIDGroupPair type (a…
808c469 
…ws-controllers-k8s#187)

Addresses: aws-controllers-k8s/community#2059

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-hilaly a-hilaly

Labels
kind/feature Categorizes issue or PR as related to a new feature. service/ec2 Indicates issues or PRs that are related to ec2-controller.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-hilaly @adriananeci