Skip to content

Generating ElasticsearchService aws-sdk-go 1.38.10 causes compile failures #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaypipes opened this issue Sep 3, 2021 · 5 comments
Closed
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jaypipes
Copy link
Collaborator

jaypipes commented Sep 3, 2021

When regenerating the elasticsearchservice-controller with aws-sdk-go v1.38.10 and ACK runtime/code-generator v0.13.0, I'm getting the following compilation failures:

pkg/resource/elasticsearch_domain/sdk.go:1297:31: r.ko.Spec.AutoTuneOptions.RollbackOnDisable undefined (type *"github.com/aws-controllers-k8s/elasticsearchservice-controller/apis/v1alpha1".AutoTuneOptionsInput has no field or method RollbackOnDisable)
pkg/resource/elasticsearch_domain/sdk.go:1298:54: r.ko.Spec.AutoTuneOptions.RollbackOnDisable undefined (type *"github.com/aws-controllers-k8s/elasticsearchservice-controller/apis/v1alpha1".AutoTuneOptionsInput has no field or method RollbackOnDisable)

It's probably due to mismatched Go types for input and output shapes (#178) but will need investigating.

@jaypipes jaypipes added kind/bug Categorizes issue or PR as related to a bug. area/code-generation Issues or PRs as related to controllers or docs code generation Elasticsearch labels Sep 3, 2021
@jaypipes
Copy link
Collaborator Author

jaypipes commented Sep 3, 2021

For now, I'm just going to comment these setters out in the update path.

@ack-bot
Copy link
Collaborator

ack-bot commented Dec 2, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-bot ack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 1, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-bot ack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 1, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 31, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

@ack-bot ack-bot closed this as completed Jan 31, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 31, 2022

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

2 participants