-
Notifications
You must be signed in to change notification settings - Fork 268
Documentation regarding helm 3.7 is incorrect #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for bringing it to our attention. Coming week, we will generate the new release of all ACK controllers, which will be compatible with helm 3.7, and also consistent with our documentation. |
Issue #, if available: aws-controllers-k8s/community#988 Description of changes: * release artifacts for v0.0.8 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: aws-controllers-k8s/community#988 Description of changes: * release artifacts for v0.0.5 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: aws-controllers-k8s/community#988 Description of changes: * release artifacts for v0.0.6 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: aws-controllers-k8s/community#988 Description of changes: * release artifacts for v0.0.6 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: aws-controllers-k8s/community#988 Description of changes: * release artifacts for v0.0.6 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Please reopen if you still see concerns. |
@vijtrip2 I am still encountering this issue with the SageMaker chart v0.1.0:
|
Yes because sagemaker controller haven't been built and released with helm3.7 . |
Issue #, if available: #988 Description of changes: Current documentation may be confusing to customers as `SageMaker` repo hasn't released with `3.7 `helm charts yet. This upgrade is coming soon however in the meantime we want the docs to reflect the current installation process of `Sagemaker` Controller By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…controllers-k8s#1018) Issue #, if available: aws-controllers-k8s#988 Description of changes: Current documentation may be confusing to customers as `SageMaker` repo hasn't released with `3.7 `helm charts yet. This upgrade is coming soon however in the meantime we want the docs to reflect the current installation process of `Sagemaker` Controller By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Describe the bug
The installation docs prescribe using a version of helm greater than or equal to 3.7 due to a breaking change introduced in helm 3.7.
This appears to be incorrect and should instead say use a version of helm less than 3.7?
Steps to reproduce
Using helm 3.7
Using 3.6.3:
Expected outcome
Documentation regarding helm 3.7 to be accurate.
The text was updated successfully, but these errors were encountered: