Skip to content

Documentation regarding helm 3.7 is incorrect #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alphamichael opened this issue Sep 25, 2021 · 4 comments
Closed

Documentation regarding helm 3.7 is incorrect #988

alphamichael opened this issue Sep 25, 2021 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@alphamichael
Copy link

Describe the bug
The installation docs prescribe using a version of helm greater than or equal to 3.7 due to a breaking change introduced in helm 3.7.

This appears to be incorrect and should instead say use a version of helm less than 3.7?

Steps to reproduce
Using helm 3.7

$ helm version 
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}
$ export HELM_EXPERIMENTAL_OCI=1 ; helm pull oci://public.ecr.aws/aws-controllers-k8s/s3-chart --version v0.0.4 -d s3-chart
Error: manifest does not contain minimum number of descriptors (2), descriptors found: 1
$

Using 3.6.3:

$ helm version
version.BuildInfo{Version:"v3.6.3", GitCommit:"d506314abfb5d21419df8c7e7e68012379db2354", GitTreeState:"clean", GoVersion:"go1.16.5"}
$ export HELM_EXPERIMENTAL_OCI=1 ; helm pull oci://public.ecr.aws/aws-controllers-k8s/s3-chart --version v0.0.4 -d s3-chart
v0.0.4: Pulling from public.ecr.aws/aws-controllers-k8s/s3-chart
$

Expected outcome
Documentation regarding helm 3.7 to be accurate.

@alphamichael alphamichael added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2021
@vijtrip2
Copy link
Contributor

Thank you for bringing it to our attention.
In this case, v0.0.4(released 10 days ago) was generated using helm 3.6

Coming week, we will generate the new release of all ACK controllers, which will be compatible with helm 3.7, and also consistent with our documentation.

ack-bot pushed a commit to aws-controllers-k8s/ecr-controller that referenced this issue Sep 27, 2021
Issue #, if available: aws-controllers-k8s/community#988

Description of changes:
* release artifacts for v0.0.8

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot pushed a commit to aws-controllers-k8s/s3-controller that referenced this issue Sep 27, 2021
Issue #, if available: aws-controllers-k8s/community#988

Description of changes:
* release artifacts for v0.0.5

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot pushed a commit to aws-controllers-k8s/mq-controller that referenced this issue Sep 27, 2021
Issue #, if available: aws-controllers-k8s/community#988

Description of changes:
* release artifacts for v0.0.6

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot pushed a commit to aws-controllers-k8s/apigatewayv2-controller that referenced this issue Sep 27, 2021
Issue #, if available: aws-controllers-k8s/community#988

Description of changes:
* release artifacts for v0.0.6

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot pushed a commit to aws-controllers-k8s/dynamodb-controller that referenced this issue Sep 27, 2021
Issue #, if available: aws-controllers-k8s/community#988

Description of changes:
* release artifacts for v0.0.6

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@vijtrip2 vijtrip2 self-assigned this Sep 27, 2021
@vijtrip2
Copy link
Contributor

Please reopen if you still see concerns.
ACK team released new controllers which are compatible with Helm-3.7 and consistent with documentation.

@samruthr
Copy link

samruthr commented Oct 5, 2021

@vijtrip2 I am still encountering this issue with the SageMaker chart v0.1.0:

➜ helm version
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.17"}
➜ helm pull oci://public.ecr.aws/aws-controllers-k8s/sagemaker-chart --version v0.1.0 -d sagemaker-chart
Error: manifest does not contain minimum number of descriptors (2), descriptors found: 1

@vijtrip2
Copy link
Contributor

vijtrip2 commented Oct 5, 2021

Yes because sagemaker controller haven't been built and released with helm3.7 .
Sorry for the inconsistency among helm version compatibility but sagemaker team handle release of their own controller. I will reach out to them to make a new release. Current release should work well with helm 3.6

ack-bot pushed a commit that referenced this issue Oct 11, 2021
Issue #, if available:
#988 
Description of changes:
Current documentation may be confusing to customers as `SageMaker` repo hasn't released with `3.7 `helm charts yet. This upgrade is coming soon however in the meantime we want the docs to reflect the current installation process of `Sagemaker` Controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RedbackThomson pushed a commit to RedbackThomson/ack-community that referenced this issue Oct 11, 2021
…controllers-k8s#1018)

Issue #, if available:
aws-controllers-k8s#988 
Description of changes:
Current documentation may be confusing to customers as `SageMaker` repo hasn't released with `3.7 `helm charts yet. This upgrade is coming soon however in the meantime we want the docs to reflect the current installation process of `Sagemaker` Controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants