Skip to content

Update to ACK runtime 0.7.1 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2021
Merged

Update to ACK runtime 0.7.1 #10

merged 3 commits into from
Jul 22, 2021

Conversation

RedbackThomson
Copy link
Contributor

@RedbackThomson RedbackThomson commented Jul 21, 2021 •
edited
Loading

Brings in ACK runtime 0.7.1 and updates the generator to support adopting Backups.

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from a-hilaly and vijtrip2 July 21, 2021 20:00
jaypipes
jaypipes approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaypipes
Copy link
Collaborator

/retest

@jaypipes
Copy link
Collaborator

/retest dynamodb-kind-e2e

@ack-bot
Copy link
Collaborator

ack-bot commented Jul 22, 2021

@jaypipes: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test dynamodb-kind-e2e
  • /test dynamodb-unit-test

Use /test all to run all jobs.

In response to this:

/retest dynamodb-kind-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RedbackThomson
Copy link
Contributor Author

Waiting for aws-controllers-k8s/runtime#34 to fix status issues in e2e tests

@RedbackThomson RedbackThomson changed the title Update to ACK runtime 0.7.0 Update to ACK runtime 0.7.1 Jul 22, 2021
@vijtrip2
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,jaypipes,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 1e45637 into aws-controllers-k8s:main Jul 22, 2021
@RedbackThomson RedbackThomson deleted the runtime-0.7.0 branch July 22, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

Assignees

@vijtrip2 vijtrip2

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedbackThomson @jaypipes @ack-bot @vijtrip2