Skip to content

chore: Ensure controller understands both ENABLE & ENABLED contributorInsights #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

chore: Ensure controller understands both ENABLE & ENABLED contributorInsights #129

merged 2 commits into from
Apr 10, 2025
+46 −24

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Apr 8, 2025 •
edited
Loading

Description of changes:
These changes allow users to define both ENABLE/DISABLE and ENABLED/DISABLED value for the ContributorInsights field.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 April 8, 2025 16:14
@ack-prow ack-prow bot added the approved label Apr 8, 2025
@michaelhtm michaelhtm force-pushed the chore/ed branch 4 times, most recently from fdf9ff3 to d2103dc Compare April 8, 2025 22:34
@michaelhtm
fix: increate test wait time
Loading
Loading status checks…
edff42d
a-hilaly
a-hilaly approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelhtm
Copy link
Member Author

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 8, 2025 •
edited
Loading

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
dynamodb-verify-attribution edff42d link false /test dynamodb-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rushmash91
rushmash91 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@rushmash91 rushmash91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we add a PR description about the behavior..

pkg/resource/table/hooks.go
}
// latestInsight will always be either ENABLED or DISABLED, since we requeue at readOne if its not
Copy link
Member

@rushmash91 rushmash91 Apr 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if the desired ContributorInsights is nil, we do not compare?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

@rushmash91
Copy link
Member

thanks @michaelhtm !!!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 97ca266 into aws-controllers-k8s:main Apr 10, 2025
6 of 7 checks passed
michaelhtm added a commit to michaelhtm/ack-dynamodb-controller that referenced this pull request Apr 10, 2025
@michaelhtm
Adress early return in hooks.go customPreCompare
fb99731 
aws-controllers-k8s#129 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly

@rushmash91 rushmash91

@jlbutler jlbutler

Assignees

@rushmash91 rushmash91

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelhtm @rushmash91 @a-hilaly