Skip to content

Bugfix/compare attribute definitions #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 24, 2023
Merged

Bugfix/compare attribute definitions #59

merged 7 commits into from
Mar 24, 2023

Conversation

Julian-Chu
Copy link
Contributor

Issue: aws-controllers-k8s/community#1599

Description of changes:

  • ignore default compare function of attribute definitions by update generator.yaml
  • implemented custom compare/delta function for attribute definitions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@ack-prow ack-prow bot requested review from RedbackThomson and vijtrip2 February 3, 2023 11:32
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2023
@ack-prow
Copy link

ack-prow bot commented Feb 3, 2023

Hi @Julian-Chu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Julian-Chu
Copy link
Contributor Author

/retest

@ack-prow
Copy link

ack-prow bot commented Feb 3, 2023

@Julian-Chu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Julian-Chu Julian-Chu marked this pull request as ready for review February 3, 2023 11:48
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@jaypipes
Copy link
Collaborator

jaypipes commented Feb 6, 2023

@a-hilaly can you ok-to-test this please?

@a-hilaly
Copy link
Member

a-hilaly commented Feb 6, 2023

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2023
@mustafasencer
Copy link

@a-hilaly @jaypipes Does the PR seem ok to you? Can we move forward with this approach?

We started the migration process for our dynamodb resources and this one is unfortunately a blocker for now.

Thanks!

@a-hilaly
Copy link
Member

Hi @mustafasencer #30 will include a variation of this patch (while keeping the commit message). For now we cannot merge due to lack of testing. #30 will have heaving testing of most of the possible update combinations.

jaypipes
jaypipes reviewed Mar 20, 2023
View reviewed changes
pkg/resource/table/hooks.go Outdated
// computeAttributeDefinitions compares two AttributeDefinition arrays and return three different list
// containing the added, updated and removed tags.
// The removed tags only contains the Key of tags
func computeAttributeDefinitions(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this function actually being used anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaypipes thanks for comments.
I made it too complex, now I just copy qualAttributeDefinitions from PR #30 to make the resource can be synced after creation. It would unblock our migration. 😄

@mustafasencer
Copy link

@a-hilaly @jaypipes Thank you for the prompt response 🙏 So as I understand, we will be waiting for #30 to be merged as it address the general issue, am I correct? Should we close this PR then?

@Julian-Chu Julian-Chu requested review from jaypipes and removed request for RedbackThomson and vijtrip2 March 23, 2023 22:10
jaypipes
jaypipes approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @Julian-Chu! All looks good now :)

@ack-prow ack-prow bot added the approved label Mar 24, 2023
@jaypipes
Copy link
Collaborator

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, Julian-Chu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 78927ab into aws-controllers-k8s:main Mar 24, 2023
@Julian-Chu Julian-Chu deleted the bugfix/compare_attribute_defintions branch March 26, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

Assignees

@jaypipes jaypipes

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Julian-Chu @jaypipes @a-hilaly @mustafasencer