Skip to content

Commit b6dff77

Browse files
authored
fix: eventual consistency in vpc tests (#260)
Description of changes: Increasing the update wait time for vpc resource tests. The initial wait time was determined when ec2 had fewer resources. The more resources the more we see eventual consistency. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 2cbd0a4 commit b6dff77

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/e2e/tests/test_vpc.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
CREATE_WAIT_AFTER_SECONDS = 10
3333
DELETE_WAIT_AFTER_SECONDS = 10
34-
MODIFY_WAIT_AFTER_SECONDS = 5
34+
MODIFY_WAIT_AFTER_SECONDS = 15
3535

3636
def get_vpc_attribute(ec2_client, vpc_id: str, attribute_name: str) -> dict:
3737
return ec2_client.describe_vpc_attribute(Attribute=attribute_name, VpcId=vpc_id)
@@ -269,6 +269,7 @@ def test_update_disallow_default_security_group_rule(self, ec2_client, simple_vp
269269

270270
time.sleep(CREATE_WAIT_AFTER_SECONDS)
271271

272+
k8s.wait_on_condition(ref, "ACK.ResourceSynced", "True", wait_periods=5)
272273
# Check VPC exists in AWS
273274
ec2_validator = EC2Validator(ec2_client)
274275
ec2_validator.assert_vpc(resource_id)

0 commit comments

Comments
 (0)