Skip to content

fix: eventual consistency in vpc tests #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michaelhtm
Copy link
Member

Description of changes:
Increasing the update wait time for vpc resource tests. The initial wait
time was determined when ec2 had fewer resources. The more resources
the more we see eventual consistency.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Increasing the update wait time for vpc resource tests. The initial wait
time was determined when ec2 had fewer resources. The more resources
the more we see eventual consistency.
Copy link

ack-prow bot commented Apr 7, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-verify-attribution 56a3749 link false /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler April 7, 2025 18:51
@ack-prow ack-prow bot added the approved label Apr 7, 2025
@rushmash91
Copy link
Member

thanks @michaelhtm !!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2025
Copy link

ack-prow bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit b6dff77 into aws-controllers-k8s:main Apr 7, 2025
6 of 7 checks passed
@a-hilaly
Copy link
Member

a-hilaly commented Apr 7, 2025

Yay, dankeshoen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants