Fix critical error in flowlogs pkg

[mattzech]

Issue #, if available: 1931

Description of changes:
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/ec2#DescribeFlowLogsOutput

FlowLogID is not a field defined in DescribeFlowlogsOutput. Need to go inside the resp.FlowLog[] to get the FlowLogID. This is causing a crash any time FlowLog resource is created because it is always going to return index out of bounds.

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattzech
Once this PR has been reviewed and has the lgtm label, please assign jljaco for approval by writing /assign @jljaco in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

Hi @mattzech. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mattzech]

I realize my code may not be exactly right, I am just basing this off my knowledge of the sdk.

[a-hilaly]

Hi @mattzech - thanks for the PR! I just checked CreateFlowLogsOutput struct - and it looks like it doesn't have a FlowLogs field.

[a-hilaly]

@mattzech I just realized that you are pointing to an sdk v2 link, while in ACK we are using the v1

[mattzech]

@a-hilaly Ah, that would make sense as to why I did not see it. Thank you for the response. Did you get a chance to look at the issue I referenced? Any basic FlowLogs resource creation panics and points to this line in the code

[a-hilaly]

Taking a look now!

[ack-bot]

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[ack-bot]

Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

[a-hilaly]

Hi @mattzech - sorry for the delays. the since the sdk files are generated we needed a hook to be used here. It happened that @nnbu just fixed that in #157 - so we can close this one.

Thank you both!!