Remove subnet UserIDGroupPairs.GroupID references
#192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
force-pushed
the
partial-revert/cd75ad971e604ba0e1f05a4e2f7838cd20baea79
branch
2 times, most recently
from
0d673ea to
6fb4468
Compare
…ollers-k8s#191) Issue : aws-controllers-k8s/community#2075 Description of changes: The issue is that vpce CR status is not updated. This happens because when vpce is created, it takes around a minute for it to be created in aws. Due to this, it's status is kept `pending`. But there is no sync enforced on the reconciler. Due to this, reconciliation happens after 10h default time. At this time, status would be set correctly. This fix enforces reconciliation to make sure CR is updated correctly when vpce creation in aws is successful. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly
force-pushed
the
partial-revert/cd75ad971e604ba0e1f05a4e2f7838cd20baea79
branch
from
6fb4468 to
e883ea9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nnbu
pushed a commit
to nnbu/ack-ec2-controller
that referenced
this pull request
Sep 18, 2024
…k8s#192) Partial revert of aws-controllers-k8s@cd75ad9 Initially our intention was to generate code to reference for both `GroupName` and `GroupID` fields in the `UserIDGroupPairs`. However what we (I) missed was that the code-generator processes the references fields, omits "ID" and "Name" name fields, and infers names for the referenced fields (e.g `GroupName` -> `GroupRef` and `GroupID` -> `GroupRef`. This confused the ACK code generator since both `GroupName` and `GroupID` needed a reference field called `GroupRef`. This caused some confusion at the code generation level, triggering some validation issues and introduced a regression in our references code. In a attempt to address the regression, we will first omit one of the references (GroupID), regenerate the code and address this in the code-generator later on. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of cd75ad9
Initially our intention was to generate code to reference for both
GroupNameand
GroupIDfields in theUserIDGroupPairs. However what we (I) missed wasthat the code-generator processes the references fields, omits "ID" and "Name"
name fields, and infers names for the referenced fields (e.g
GroupName->GroupRefandGroupID->GroupRef. This confused the ACK codegenerator since both
GroupNameandGroupIDneeded a reference field calledGroupRef. This caused some confusion at the code generation level, triggering somevalidation issues and introduced a regression in our references code.
In a attempt to address the regression, we will first omit one of the references
(GroupID), regenerate the code and address this in the code-generator later on.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.