Set correct userIDGroupPairs defaults for SecurityGroups CRs.
#194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
force-pushed
the
securitygroups/fix-useridgrouppairs
branch
from
dd123dc to
b2467c4
Compare
- Mark `UserIDGroupPairs.GroupName` as non-required (at the CRD level)
- Default `UserIDGroupPairs.{VPCID,GroupID}` to the parent security group ID / linked-vpcID
- Add e2e tests for UserIDGroupPairs
a-hilaly
force-pushed
the
securitygroups/fix-useridgrouppairs
branch
from
b2467c4 to
983332a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nnbu
pushed a commit
to nnbu/ack-ec2-controller
that referenced
this pull request
Sep 18, 2024
…s-controllers-k8s#194) Closes aws-controllers-k8s/community#2068, aws-controllers-k8s/community#2061, and aws-controllers-k8s/community#2058 The EC2 API for setting ingress/egress rules has many special restrictions, making its behavior hard to predict. For example, `GroupName` should only be used with default VPCs. When using non default VPCs users should use `GroupID` instead To address this problem, we are introducing a defaulting mechanism to help the controller infer and use the correct `GroupID` when a user doesnt provide one. You might wonder why all the trouble, and why not just use ACK resource references? Well.. this is necessary because ACK resource references cannot do self references, making fully declarative egress/ingress rule definition impossible in some cases. Changes: - Mark `UserIDGroupPairs.GroupName` as non-required (at the CRD level) - Default `UserIDGroupPairs.GroupID` to the parent security group ID - Default `UserIDGroupPairs.VPCID` to the VPC of the parent security group - Add more e2e tests for `UserIDGroupPairs` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes aws-controllers-k8s/community#2068,
aws-controllers-k8s/community#2061, and
aws-controllers-k8s/community#2058
The EC2 API for setting ingress/egress rules has many special restrictions,
making its behavior hard to predict. For example,
GroupNameshould only beused with default VPCs. When using non default VPCs users should use
GroupIDinstead
To address this problem, we are introducing a defaulting mechanism to help the
controller infer and use the correct
GroupIDwhen a user doesnt provide one.You might wonder why all the trouble, and why not just use ACK resource references?
Well.. this is necessary because ACK resource references cannot do self
references, making fully declarative egress/ingress rule definition impossible in some
cases.
Changes:
UserIDGroupPairs.GroupNameas non-required (at the CRD level)UserIDGroupPairs.GroupIDto the parent security group IDUserIDGroupPairs.VPCIDto the VPC of the parent security groupUserIDGroupPairsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.