Refactor and uniform tags comparison/update logic #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ack-prow
bot
added
the
do-not-merge/work-in-progress
a-hilaly
force-pushed
the
refactor-tags
branch
2 times, most recently
from
2545661 to
58f6b17
Compare
a-hilaly
changed the title
ack-prow
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, yuxiang-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nnbu
pushed a commit
to nnbu/ack-ec2-controller
that referenced
this pull request
Sep 18, 2024
…s#196) Fixes aws-controllers-k8s/community#2063 During the early days of ACK, the ec2 controller didn't have a lot of CRDs and most of the work around tag handling was some sort of copy/pasta from resource to resource. Time passed and now ec2-controller has 15 resources each with a slightly different tags handling implementations - making it very hard for us to maintain and bug fix if something goes wrong. This patch does a few things to simplify the life of an ACK developer: - Moves a lot of the tags handling logic into a single, simple and maintainable package (`pkg/tags`). - Rely back on generated tags delta computation (back then this wasn't supported) - Add type safety around the algorithm that was used to compare two array slices. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws-controllers-k8s/community#2063
During the early days of ACK, the ec2 controller didn't have a lot of CRDs and most of the work around tag handling was some sort of copy/pasta from resource to resource. Time passed and now ec2-controller has 15 resources each with a slightly different tags handling implementations - making it very hard for us to maintain and bug fix if something goes wrong.
This patch does a few things to simplify the life of an ACK developer:
pkg/tags).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.