Add tests to ensure resource reference is not replaced by controller #220
Conversation
michaelhtm
force-pushed
the
add-ensure-reference-test
branch
7 times, most recently
from
7cebbda to
700ddd0
Compare
These tests ensure that after an update, the controller won't replace the resource reference with the ID itself.
This commit addresses a customer issue, where the update operation was overwriting the routeTable spec, getting rid of the reference names placed by the user, and replacing them with the values retrieved from the AWS API. In the future we want to make changes in how controllers are generated to ensure the sdkfind has places in store to support not overriding user defined resource references
michaelhtm
force-pushed
the
add-ensure-reference-test
branch
from
700ddd0 to
52b81c8
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #1880
Description of changes:
These tests ensure that after an update,
the controller won't replace the resource
reference with the ID itself.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.