Skip to content

Optimize security group rule management and improve error handling #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

Optimize security group rule management and improve error handling #227

merged 1 commit into from
Oct 9, 2024

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Oct 9, 2024 •
edited
Loading

Fixes aws-controllers-k8s/community#2186

  • Implement batch processing for ingress and egress rules (1000 at a time)
    to comply with API limitations
  • Refactor createSecurityGroupRules and deleteSecurityGroupRules to handle
    large numbers of rules efficiently
  • Improve error handling using deferred functions in multiple methods

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Optimize security group rule management and improve error handling
9843d39 
- Implement batch processing for ingress and egress rules (1000 at a time)
  to comply with API limitations
- Refactor `createSecurityGroupRules` and `deleteSecurityGroupRules` to handle
  large numbers of rules efficiently
- Improve error handling using deferred functions in multiple methods
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 9, 2024

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-verify-attribution 9843d39 link false /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot requested a review from LikithaVemulapalli October 9, 2024 22:00
@ack-prow ack-prow bot added the approved label Oct 9, 2024
michaelhtm
michaelhtm reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitteshoen 👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit bd45cde into aws-controllers-k8s:main Oct 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm left review comments

@LikithaVemulapalli LikithaVemulapalli Awaiting requested review from LikithaVemulapalli

Assignees

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ec2-controller] combine Security Group rules creation/deletion API calls
2 participants
@a-hilaly @michaelhtm