Skip to content

feat(NetworkACL): Filter Default Rules from Delta #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-03-10T20:08:48Z"
build_hash: cfbd9fc8a32a564e2f05252b60248053ff09e744
build_date: "2025-03-25T22:26:20Z"
build_hash: 3722729cebe6d3c03c7e442655ef0846f91566a2
go_version: go1.24.0
version: v0.43.2-4-gcfbd9fc
version: v0.43.2-7-g3722729
api_directory_checksum: b31faecf6092fab9677498f3624e624fee4cbaed
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
generator_config_info:
file_checksum: 4f9d21bd7c46b495cd9374e454a3a0e1e6de5d08
file_checksum: 33b2c8e790a68bd28b5efe9faa3b8e5fb980d1f4
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 2 additions & 0 deletions apis/v1alpha1/generator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,8 @@ resources:
input_fields:
NetworkAclId: Id
hooks:
delta_pre_compare:
code: customPreCompare(delta, a, b)
sdk_create_post_build_request:
template_path: hooks/network_acl/sdk_create_post_build_request.go.tpl
sdk_file_end:
Expand Down
2 changes: 2 additions & 0 deletions generator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,8 @@ resources:
input_fields:
NetworkAclId: Id
hooks:
delta_pre_compare:
code: customPreCompare(delta, a, b)
sdk_create_post_build_request:
template_path: hooks/network_acl/sdk_create_post_build_request.go.tpl
sdk_file_end:
Expand Down
4 changes: 3 additions & 1 deletion pkg/resource/capacity_reservation/delta.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions pkg/resource/capacity_reservation/manager.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 17 additions & 44 deletions pkg/resource/capacity_reservation/tags.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pkg/resource/dhcp_options/delta.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions pkg/resource/dhcp_options/manager.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 17 additions & 44 deletions pkg/resource/dhcp_options/tags.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pkg/resource/elastic_ip_address/delta.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions pkg/resource/elastic_ip_address/manager.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading