Skip to content

fix: remove printf with no constant #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
+6 −6
Merged

fix: remove printf with no constant #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ack_generate_info:
build_date: "2025-03-28T15:21:59Z"
build_date: "2025-03-31T18:41:05Z"
build_hash: 3722729cebe6d3c03c7e442655ef0846f91566a2
go_version: go1.24.0
go_version: go1.24.1
version: v0.43.2-7-g3722729
api_directory_checksum: bb3f7a9b3924fdbe63a4082a9134b3f1f653979b
api_version: v1alpha1
Expand Down
4 changes: 2 additions & 2 deletions pkg/resource/vpc_peering_connection/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions templates/hooks/vpc_peering_connection/sdk_update_pre_build_request.go.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
if delta.DifferentAt("Spec.AcceptRequest") {
// Throw a Terminal Error, if the field was set to 'true' and is now set to 'false'
if desired.ko.Spec.AcceptRequest == nil || !*desired.ko.Spec.AcceptRequest {
msg := fmt.Sprintf("You cannot set AcceptRequest to false after setting it to true")
return nil, ackerr.NewTerminalError(fmt.Errorf(msg))
msg := "you cannot set AcceptRequest to false after setting it to true"
return nil, ackerr.NewTerminalError(fmt.Errorf("%s", msg))
// Accept the VPC Peering Connection Request, if the field is set to 'true' and is still at status Pending Acceptance
} else if *latest.ko.Status.Status.Code == "pending-acceptance" {
Expand Down