Skip to content

Release artifacts for release v1.4.1 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Release artifacts for release v1.4.1 #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0427d5
Release artifacts for release v1.4.1
michaelhtm Apr 3, 2025
e4c2a15
fix: wait on condition for flaky tests
michaelhtm Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/ec2-controller
newTag: 1.4.0
newTag: 1.4.1
4 changes: 2 additions & 2 deletions helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: ec2-chart
description: A Helm chart for the ACK service controller for Amazon Elastic Cloud Compute (EC2)
version: 1.4.0
appVersion: 1.4.0
version: 1.4.1
appVersion: 1.4.1
home: https://github.com/aws-controllers-k8s/ec2-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ .Chart.Name }} has been installed.
This chart deploys "public.ecr.aws/aws-controllers-k8s/ec2-controller:1.4.0".
This chart deploys "public.ecr.aws/aws-controllers-k8s/ec2-controller:1.4.1".

Check its status by running:
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"
Expand Down
2 changes: 1 addition & 1 deletion helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/ec2-controller
tag: 1.4.0
tag: 1.4.1
pullPolicy: IfNotPresent
pullSecrets: []

Expand Down
4 changes: 3 additions & 1 deletion test/e2e/tests/test_vpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ def test_crud_tags(self, ec2_client, simple_vpc):
resource = k8s.get_resource(ref)
assert len(resource["spec"]["tags"]) == 0

k8s.wait_on_condition(ref, "ACK.ResourceSynced", "True", wait_periods=5)
# Delete k8s resource
_, deleted = k8s.delete_custom_resource(ref)
assert deleted is True
Expand Down Expand Up @@ -282,7 +283,7 @@ def test_update_disallow_default_security_group_rule(self, ec2_client, simple_vp
}
k8s.patch_custom_resource(ref, updates)
time.sleep(MODIFY_WAIT_AFTER_SECONDS)

k8s.wait_on_condition(ref, "ACK.ResourceSynced", "True", wait_periods=5)
# Make sure default security group rule is deleted
assert not contains_default_sg_rule(ec2_client, resource_id)

Expand Down Expand Up @@ -480,6 +481,7 @@ def test_vpc_updation_multiple_cidr(self,ec2_client):
k8s.patch_custom_resource(ref, updates)
time.sleep(MODIFY_WAIT_AFTER_SECONDS)

k8s.wait_on_condition(ref, "ACK.ResourceSynced", "True", wait_periods=5)
# Re-Validate CIDR Blocks State
vpc = ec2_validator.get_vpc(resource_id)
assert vpc['CidrBlockAssociationSet'][0]['CidrBlockState']['State'] == "associated"
Expand Down