Skip to content

add VPCEndpoint reference test #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 29, 2022
Merged

add VPCEndpoint reference test #44

merged 7 commits into from
Mar 29, 2022

Conversation

brycahta
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • Adds test coverage for resolving references using VPCEndpoint

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from bwagner5 and vijtrip2 March 23, 2022 20:39
@brycahta
Copy link
Contributor Author

/retest

Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise good to go

@brycahta
Copy link
Contributor Author

/retest

@brycahta
Copy link
Contributor Author

/retest

not playing /retest roulette. there were some dangling resources in the test account that may have contributed to failure

@vijtrip2
Copy link

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,brycahta,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 34a6747 into aws-controllers-k8s:main Mar 29, 2022
@brycahta brycahta deleted the ref branch March 29, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants