Add route table assocations to Subnet
#45
Conversation
There was a problem hiding this comment.
@RedbackThomson great work on this. You made the user experience of associating route tables to subnets entirely painless and aligned with the k8s resource model.
Couple teeny things to address inline but this is very close.
| @@ -897,6 +897,7 @@ type Explanation struct { | |||
| ExplanationCode *string `json:"explanationCode,omitempty"` | |||
| MissingComponent *string `json:"missingComponent,omitempty"` | |||
| PacketField *string `json:"packetField,omitempty"` | |||
| Protocols []*string `json:"protocols,omitempty"` | |||
There was a problem hiding this comment.
Interesting.. did this come in from an updated aws-sdk-go version or something?
There was a problem hiding this comment.
No clue why this showed up, honestly. I haven't touched the SDK version afaik
RedbackThomson
force-pushed
the
subnet-rt-assoc
branch
from
e141ab7 to
98d2d4d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brycahta, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes aws-controllers-k8s/community#1219
Description of changes:
Generates the
SubnetCRD with a new custom fieldRouteTables, which represent an array of route table IDs. Route tables are associated with theSubnetusing theAssociateRouteTableAPI call, and then updated by deleting the association (usingDisassociateRouteTable) and re-associating.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.