Skip to content

Add nested resource reference for RouteTable #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 26, 2022
Merged

Add nested resource reference for RouteTable #54

merged 5 commits into from
May 26, 2022

Conversation

RedbackThomson
Copy link
Contributor

Description of changes:
Adds resource references for RouteTable.Routes structs using the latest code-generator update

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from bwagner5 and jaypipes May 9, 2022 19:44
@RedbackThomson
Copy link
Contributor Author

/hold

Need to fix an error where the runtime will patch the concrete ID into the struct because the length and order of the routes as described by the API don't match the spec.

@ack-bot ack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2022
@RedbackThomson
Copy link
Contributor Author

/unhold

I've pushed a fix that lets resource references work for the initial create. We need to fix aws-controllers-k8s/community#1291 before we can go GA with this CRD, though. However, the solution for that issue will probably be in runtime and so there's no more work for here.

@ack-bot ack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2022
brycahta
brycahta reviewed May 17, 2022
View reviewed changes
@brycahta
Copy link
Contributor

@RedbackThomson was the e2e test failure expected given the issue? Lmk if you need me to cleanup the test acct to re-run.

@RedbackThomson
Copy link
Contributor Author

/test ec2-kind-e2e

brycahta
brycahta reviewed May 17, 2022
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

brycahta
brycahta approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,brycahta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 1fcd9e0 into aws-controllers-k8s:main May 26, 2022
@RedbackThomson RedbackThomson deleted the nested-refs branch May 26, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycahta brycahta brycahta approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@brycahta brycahta

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RedbackThomson @brycahta @ack-bot