Skip to content

Update ACK runtime to v0.19.2 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Update ACK runtime to v0.19.2 #56

merged 3 commits into from
Jun 27, 2022

Conversation

brycahta
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#1363

Description of changes:

  • Updates go.mod to use runtime v0.19.2
  • Replace TagSpecifications field with Tags otherwise code-generator will fail stating resource does not have 'Tags' field; required to update to latest runtime

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from jaypipes and vijtrip2 June 27, 2022 20:40
Copy link

@vijtrip2 vijtrip2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will unblock the ec2 runtime upgrade. Thanks!
Do you have issues tracking following:

  1. Adding updateTags functionality for all ec2 resources
  2. Adding e2e tests to verify tag creation and update

@brycahta
Copy link
Contributor Author

@vijtrip2
Copy link

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 9562a9e into aws-controllers-k8s:main Jun 27, 2022
@brycahta brycahta deleted the tags-on-tags branch June 28, 2022 14:55
ack-bot pushed a commit that referenced this pull request Jun 28, 2022
Issue #, if available: N/A

Description of changes:
* releasing manually after updating ack runtime: #56

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants