add immutability check for nodegroup fields

Author: rushmash91

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2025-03-14T20:25:33Z"
-  build_hash: 0ab258c51775fd52af32e649da00d57373b20869
-  go_version: go1.24.0
-  version: v0.43.2-6-g0ab258c
-api_directory_checksum: feb947454f62a1c6a36512771ee31f36ae7bcb6d
+  build_date: "2025-04-01T06:11:19Z"
+  build_hash: a2d05644d640d09599c7a075655c6ef7c72b765f
+  go_version: go1.24.1
+  version: v0.44.0-1-ga2d0564
+api_directory_checksum: 28323c8c90317b6ded6a625dd0f3e2b652c91468
 api_version: v1alpha1
 aws_sdk_go_version: v1.32.6
 generator_config_info:
-  file_checksum: 687d1b51c5afe75b62b50c3c32c83d7e6cadc3e3
+  file_checksum: 32b67ddca993ba172f22fc079e76748027b9749b
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -312,6 +312,9 @@ resources:
         references:
           resource: Cluster
           path: Spec.Name
+        is_immutable: true
+      Name:
+        is_immutable: true
       NodeRole:
         references:
           service_name: iam
@@ -333,6 +336,10 @@ resources:
           resource: Subnet
           path: Status.SubnetID
         is_immutable: true
+      AmiType:
+        is_immutable: true
+      InstanceTypes:
+        is_immutable: true
       Taints:
         compare:
           is_ignored: true
@@ -523,4 +530,4 @@ ignore:
   - AssociateIdentityProviderConfigInput.ClientRequestToken
   - AssociateIdentityProviderConfigOutput.Update
   - AssociateAccessPolicyInput.PrincipalArn
-  - AssociateAccessPolicyInput.ClusterName
+  - AssociateAccessPolicyInput.ClusterName

apis/v1alpha1/nodegroup.go

@@ -85,6 +85,9 @@ spec:
                   Amazon EKS, see Customizing managed nodes with launch templates (https://docs.aws.amazon.com/eks/latest/userguide/launch-templates.html)
                   in the Amazon EKS User Guide.
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable once set
+                  rule: self == oldSelf
               capacityType:
                 description: The capacity type for your node group.
                 type: string
@@ -96,6 +99,9 @@ spec:
               clusterName:
                 description: The name of your cluster.
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable once set
+                  rule: self == oldSelf
               clusterRef:
                 description: "AWSResourceReferenceWrapper provides a wrapper around
                   *AWSResourceReference\ntype to provide more user friendly syntax
@@ -144,6 +150,9 @@ spec:
                 items:
                   type: string
                 type: array
+                x-kubernetes-validations:
+                - message: Value is immutable once set
+                  rule: self == oldSelf
               labels:
                 additionalProperties:
                   type: string
@@ -169,6 +178,9 @@ spec:
               name:
                 description: The unique name to give your node group.
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable once set
+                  rule: self == oldSelf
               nodeRole:
                 description: |-
                   The Amazon Resource Name (ARN) of the IAM role to associate with your node

cmd/controller/main.go

@@ -312,6 +312,9 @@ resources:
         references:
           resource: Cluster
           path: Spec.Name
+        is_immutable: true
+      Name:
+        is_immutable: true
       NodeRole:
         references:
           service_name: iam
@@ -333,6 +336,10 @@ resources:
           resource: Subnet
           path: Status.SubnetID
         is_immutable: true
+      AmiType:
+        is_immutable: true
+      InstanceTypes:
+        is_immutable: true
       Taints:
         compare:
           is_ignored: true
@@ -523,4 +530,4 @@ ignore:
   - AssociateIdentityProviderConfigInput.ClientRequestToken
   - AssociateIdentityProviderConfigOutput.Update
   - AssociateAccessPolicyInput.PrincipalArn
-  - AssociateAccessPolicyInput.ClusterName
+  - AssociateAccessPolicyInput.ClusterName

config/crd/bases/eks.services.k8s.aws_nodegroups.yaml

@@ -1,25 +1,25 @@
 module github.com/aws-controllers-k8s/eks-controller
 
-go 1.22.0
+go 1.23.0
 
-toolchain go1.22.5
+toolchain go1.24.1
 
 require (
 	github.com/aws-controllers-k8s/ec2-controller v1.1.0
 	github.com/aws-controllers-k8s/iam-controller v1.3.1
 	github.com/aws-controllers-k8s/kms-controller v1.0.9
-	github.com/aws-controllers-k8s/runtime v0.43.0
+	github.com/aws-controllers-k8s/runtime v0.44.0
 	github.com/aws/aws-sdk-go v1.55.5
 	github.com/aws/aws-sdk-go-v2 v1.33.0
 	github.com/aws/aws-sdk-go-v2/service/eks v1.56.5
 	github.com/aws/smithy-go v1.22.2
 	github.com/go-logr/logr v1.4.2
 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.9.0
-	k8s.io/api v0.31.0
-	k8s.io/apimachinery v0.31.0
-	k8s.io/client-go v0.31.0
-	sigs.k8s.io/controller-runtime v0.19.0
+	k8s.io/api v0.32.1
+	k8s.io/apimachinery v0.32.1
+	k8s.io/client-go v0.32.1
+	sigs.k8s.io/controller-runtime v0.20.4
 )
 
 require (
@@ -39,21 +39,20 @@ require (
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/emicklei/go-restful/v3 v3.11.0 // indirect
-	github.com/evanphx/json-patch/v5 v5.9.0 // indirect
+	github.com/evanphx/json-patch/v5 v5.9.11 // indirect
 	github.com/fsnotify/fsnotify v1.7.0 // indirect
 	github.com/fxamacker/cbor/v2 v2.7.0 // indirect
 	github.com/go-logr/zapr v1.3.0 // indirect
-	github.com/go-openapi/jsonpointer v0.19.6 // indirect
+	github.com/go-openapi/jsonpointer v0.21.0 // indirect
 	github.com/go-openapi/jsonreference v0.20.2 // indirect
-	github.com/go-openapi/swag v0.22.4 // indirect
+	github.com/go-openapi/swag v0.23.0 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
-	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
 	github.com/golang/protobuf v1.5.4 // indirect
+	github.com/google/btree v1.1.3 // indirect
 	github.com/google/gnostic-models v0.6.8 // indirect
 	github.com/google/go-cmp v0.6.0 // indirect
 	github.com/google/gofuzz v1.2.0 // indirect
 	github.com/google/uuid v1.6.0 // indirect
-	github.com/imdario/mergo v0.3.12 // indirect
 	github.com/itchyny/gojq v0.12.6 // indirect
 	github.com/itchyny/timefmt-go v0.1.3 // indirect
 	github.com/jaypipes/envutil v1.0.0 // indirect
@@ -73,24 +72,25 @@ require (
 	github.com/samber/lo v1.37.0 // indirect
 	github.com/x448/float16 v0.8.4 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
-	go.uber.org/zap v1.26.0 // indirect
-	golang.org/x/exp v0.0.0-20230515195305-f3d0a9c9a5cc // indirect
-	golang.org/x/net v0.33.0 // indirect
-	golang.org/x/oauth2 v0.21.0 // indirect
-	golang.org/x/sys v0.28.0 // indirect
-	golang.org/x/term v0.27.0 // indirect
-	golang.org/x/text v0.21.0 // indirect
-	golang.org/x/time v0.3.0 // indirect
+	go.uber.org/zap v1.27.0 // indirect
+	golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 // indirect
+	golang.org/x/net v0.37.0 // indirect
+	golang.org/x/oauth2 v0.23.0 // indirect
+	golang.org/x/sync v0.12.0 // indirect
+	golang.org/x/sys v0.31.0 // indirect
+	golang.org/x/term v0.30.0 // indirect
+	golang.org/x/text v0.23.0 // indirect
+	golang.org/x/time v0.7.0 // indirect
 	gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect
-	google.golang.org/protobuf v1.34.2 // indirect
+	google.golang.org/protobuf v1.35.1 // indirect
+	gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
-	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
-	k8s.io/apiextensions-apiserver v0.31.0 // indirect
+	k8s.io/apiextensions-apiserver v0.32.1 // indirect
 	k8s.io/klog/v2 v2.130.1 // indirect
-	k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340 // indirect
-	k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 // indirect
-	sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
-	sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
+	k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f // indirect
+	k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect
+	sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
+	sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect
 	sigs.k8s.io/yaml v1.4.0 // indirect
 )