Skip to content

Fix local-run-controller Makefile target #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

jljaco
Copy link
Contributor

@jljaco jljaco commented Jan 26, 2023

Prune obsolete aws-account-id command line argument from local-run-controller Makefile target

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-bot ack-bot added lgtm Indicates that a PR is ready to be merged. approved labels Jan 26, 2023
@RedbackThomson
Copy link
Contributor

Could you please also delete the $AUTHENTICATED_ACCOUNT_ID on line 14. That's no longer needed

@RedbackThomson
Copy link
Contributor

/lgtm cancel

@ack-bot ack-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
local-run-controller Makefile target
@jljaco jljaco force-pushed the fix-local-run-controller branch from 670cb9a to 55f170b Compare January 26, 2023 19:01
@jljaco
Copy link
Contributor Author

jljaco commented Jan 26, 2023

Could you please also delete the $AUTHENTICATED_ACCOUNT_ID on line 14. That's no longer needed

Done

@jljaco jljaco changed the title Fix local-run-controller Makefile target Fix local-run-controller Makefile target Jan 26, 2023
@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jljaco, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit a18816c into aws-controllers-k8s:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants