-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore fields added in the new SDK version #141
base: main
Are you sure you want to change the base?
Conversation
Hi @cPu1. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
@cPu1 looks like the controller isn't compiling, can you PTAL? |
Sure, please give me some time. I am juggling between a few tasks at the moment. |
eccb177
to
44128cb
Compare
Signed-off-by: cPu1 <[email protected]>
/retest |
1 similar comment
/retest |
fa429f7
to
9461e86
Compare
9461e86
to
44005e6
Compare
/retest |
1 similar comment
/retest |
/lgtm |
/lgtm cancel |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cPu1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cPu1 I tried to disable a very flaky tests but looks like some others are failing can you please take a look at this? It's blocking the 0.38.0 runtime patch |
@a-hilaly, sure, I'll look into it. That failing test should be unaffected by the changes introduced in this PR, but I'll see how best to resolve it. |
/retest |
@cPu1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #, if available:
Description of changes:
#137 added support for the
CacheCluster
resource but left ignoring newly added fields for later. This changelist adds unsupported fields to the list of fields to ignore.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.