Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore fields added in the new SDK version #141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Jul 12, 2024

Issue #, if available:

Description of changes:

#137 added support for the CacheCluster resource but left ignoring newly added fields for later. This changelist adds unsupported fields to the list of fields to ignore.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and nmvk July 12, 2024 10:34
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 12, 2024
Copy link

ack-prow bot commented Jul 12, 2024

Hi @cPu1. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2024
@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

@cPu1 looks like the controller isn't compiling, can you PTAL?

@cPu1
Copy link
Contributor Author

cPu1 commented Jul 15, 2024

@cPu1 looks like the controller isn't compiling, can you PTAL?

Sure, please give me some time. I am juggling between a few tasks at the moment.

@cPu1 cPu1 marked this pull request as draft July 22, 2024 17:04
@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
@cPu1 cPu1 force-pushed the ignore-fields branch 3 times, most recently from eccb177 to 44128cb Compare August 5, 2024 20:23
@cPu1 cPu1 marked this pull request as ready for review August 5, 2024 20:25
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
@ack-prow ack-prow bot requested a review from a-hilaly August 5, 2024 20:25
@a-hilaly
Copy link
Member

a-hilaly commented Aug 5, 2024

/retest

1 similar comment
@a-hilaly
Copy link
Member

a-hilaly commented Aug 6, 2024

/retest

@a-hilaly a-hilaly force-pushed the ignore-fields branch 3 times, most recently from fa429f7 to 9461e86 Compare August 7, 2024 04:05
@a-hilaly
Copy link
Member

/retest

1 similar comment
@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Sep 12, 2024
@a-hilaly
Copy link
Member

/lgtm cancel

@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
Copy link

ack-prow bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cPu1
Once this PR has been reviewed and has the lgtm label, please ask for approval from a-hilaly by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot removed the approved label Sep 12, 2024
@a-hilaly
Copy link
Member

@cPu1 I tried to disable a very flaky tests but looks like some others are failing can you please take a look at this? It's blocking the 0.38.0 runtime patch

@cPu1
Copy link
Contributor Author

cPu1 commented Sep 12, 2024

@cPu1 I tried to disable a very flaky tests but looks like some others are failing can you please take a look at this? It's blocking the 0.38.0 runtime patch

@a-hilaly, sure, I'll look into it. That failing test should be unaffected by the changes introduced in this PR, but I'll see how best to resolve it.

@a-hilaly
Copy link
Member

/retest

Copy link

ack-prow bot commented Oct 21, 2024

@cPu1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-attribution 44005e6 link false /test elasticache-verify-attribution
elasticache-kind-e2e 44005e6 link true /test elasticache-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants