Skip to content

Update to ACK runtime v0.44.0, code-generator v0.44.0 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Mar 27, 2025

Update to ACK runtime v0.44.0, code-generator v0.44.0



NOTE:
This PR increments the release version of service controller from v1.0.22 to v1.0.23

Once this PR is merged, release v1.0.23 will be automatically created for kms-controller

Please close this PR, if you do not want the new patch release for kms-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building kms-controller ====
Copying common custom resource definitions into kms
Building Kubernetes API objects for kms
Generating deepcopy code for kms
Generating custom resource definitions for kms
Building service controller for kms
Running GO mod tidy
Generating RBAC manifests for kms
Running gofmt against generated code for kms
Updating additional GitHub repository maintenance files
==== building kms-controller release artifacts ====
Building release artifacts for kms-v1.0.23
Generating common custom resource definitions
Generating custom resource definitions for kms
Generating RBAC manifests for kms

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Mar 27, 2025
@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm March 27, 2025 16:08
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Mar 28, 2025
@michaelhtm michaelhtm force-pushed the ack-bot/rt-v0.44.0-codegen-v0.44.0 branch from 4e8d036 to dc41b20 Compare March 28, 2025 19:48
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
Copy link

ack-prow bot commented Mar 28, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kms-verify-attribution dc41b20 link false /test kms-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
Copy link

ack-prow bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ack-bot, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 173846f into main Mar 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants