Skip to content

add reconcile-reources flag #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add reconcile-reources flag #176

wants to merge 2 commits into from

Conversation

rushmash91
Copy link
Member

@rushmash91 rushmash91 commented Apr 2, 2025 •
edited
Loading

Description of changes:

The AWS Controllers for Kubernetes (ACK) service controllers currently initialize reconcilers for all supported resource kinds, regardless of operational needs, leading to unnecessary resource consumption and potential for conflicts. We propose introducing a --reconcile-resources flag that allows operators to specify which resource kinds should be actively reconciled, enabling more efficient resource utilization and operational control. When provided with a comma-separated list of resource kinds (e.g., "Queue,Topic"), the controller will only create reconcilers for those specific resources. This enhancement maintains backward compatibility by continuing to reconcile all resources when the flag is not specified.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler April 2, 2025 18:40
a-hilaly
a-hilaly reviewed Apr 2, 2025
View reviewed changes
michaelhtm
michaelhtm reviewed Apr 2, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rushmash91!

@rushmash91 rushmash91 force-pushed the main branch 2 times, most recently from 3fac68b to ed3b8b8 Compare April 8, 2025 05:17
@rushmash91 rushmash91 mentioned this pull request Apr 8, 2025
Open
@rushmash91
Copy link
Member Author

/retest

a-hilaly
a-hilaly reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rushmash91 ! left two nits below

a-hilaly
a-hilaly approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this @rushmash91 - thank you!

@ack-prow ack-prow bot added the approved label Apr 9, 2025
michaelhtm
michaelhtm reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rushmash91 👍
/lgtm
/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2025
@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@michaelhtm
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rushmash91
Copy link
Member Author

/retest

@rushmash91
Copy link
Member Author

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2025
@rushmash91
Copy link
Member Author

/retest

@rushmash91
Copy link
Member Author

/test sagemaker-controller-test

@ack-prow ACK Prow
Copy link

ack-prow bot commented Apr 23, 2025

@rushmash91: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 9f6103e link false /test verify-attribution
sagemaker-controller-test 9f6103e link true /test sagemaker-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm left review comments

@a-hilaly a-hilaly a-hilaly approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@michaelhtm michaelhtm

Labels
approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushmash91 @michaelhtm @a-hilaly