Skip to content

Generate with SDK-V2 model #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

Generate with SDK-V2 model #147

merged 1 commit into from
Feb 5, 2025

Conversation

michaelhtm
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from rushmash91 and TiberiuGC January 27, 2025 20:16
@ack-prow ack-prow bot added the approved label Jan 27, 2025
@michaelhtm michaelhtm force-pushed the migrate/sdk-v2 branch 2 times, most recently from 33e47b9 to 3a54484 Compare January 28, 2025 00:55
@michaelhtm
Copy link
Member Author

/retest

@michaelhtm michaelhtm force-pushed the migrate/sdk-v2 branch 4 times, most recently from 5dfb919 to da5cd5f Compare February 3, 2025 22:41
@ack-prow ACK Prow
Copy link

ack-prow bot commented Feb 5, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-verify-attribution 80e1028 link false /test s3-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

a-hilaly
a-hilaly approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit ad02ac1 into aws-controllers-k8s:main Feb 5, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@rushmash91 rushmash91 Awaiting requested review from rushmash91

@TiberiuGC TiberiuGC Awaiting requested review from TiberiuGC

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelhtm @a-hilaly