test: adopt-or-create adoption-policy
#158
Conversation
michaelhtm
force-pushed
the
test/adopt-or-create
branch
7 times, most recently
from
7c2c0e5 to
4962194
Compare
michaelhtm
changed the title
adopt-or-create adoption-policy
michaelhtm
force-pushed
the
test/adopt-or-create
branch
from
4962194 to
d1a7386
Compare
michaelhtm
force-pushed
the
test/adopt-or-create
branch
from
d1a7386 to
ad234b2
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -101,10 +118,11 @@ def adopt_stack_bucket(s3_client): | |||
| @service_marker | |||
| @pytest.mark.canary | |||
| class TestAdoptionPolicyBucket: | |||
| def test_adoption_policy( | |||
| self, s3_client, adoption_policy_adopt_bucket, s3_resource | |||
| @pytest.mark.resource_data({'adoption-policy': AdoptionPolicy.ADOPT, 'filename': 'bucket_adopt', 'resource-name': 'adopt'}) | |||
There was a problem hiding this comment.
Q: Where is the "adopt" bucket being created?
There was a problem hiding this comment.
it get's created in bucket_adoption_policy fixture. The bucket itself is bootstrapped aws-controllers-k8s/community#2425
| @@ -132,6 +150,49 @@ def test_adoption_policy( | |||
| assert latest is not None | |||
| versioning = latest.Versioning() | |||
| assert versioning.status == status | |||
|
|
|||
| @pytest.mark.resource_data({'adoption-policy': AdoptionPolicy.ADOPT_OR_CREATE, 'filename': 'bucket_adopt_or_create', 'resource-name': 'adopt-or-create'}) | |||
There was a problem hiding this comment.
Q: Is there any validation that the "adopt-or-create" bucket doesn't exist prior to the test running?
There was a problem hiding this comment.
no, but we use the same bucket we used in the previous test. Just to ensure the bucket can also get adopted with adopt-or-create policy, and update is called immediately after
|
nice 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Adding two new tests for
adopt-or-create::)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.