Skip to content

fix: wait for resource sync on adoption test #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

fix: wait for resource sync on adoption test #161

merged 1 commit into from
May 6, 2025

Conversation

michaelhtm
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 May 6, 2025 20:29
@ack-prow ack-prow bot added the approved label May 6, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented May 6, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-verify-attribution 1ae779d link false /test s3-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rushmash91
rushmash91 reviewed May 6, 2025
View reviewed changes
test/e2e/tests/test_bucket_adoption_policy.py

cr = k8s.wait_resource_consumed_by_controller(ref)
cr = k8s.get_resource(ref)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rushmash91
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 680d8e5 into aws-controllers-k8s:main May 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushmash91 rushmash91 rushmash91 left review comments

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees

@rushmash91 rushmash91

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelhtm @rushmash91