Add unit tests that invoke late initialize #138
Conversation
ryansteakley
requested review from
akartsky,
mbaijal and
surajkota
as code owners
| image: 246618743249.dkr.ecr.us-west-2.amazonaws.com/sagemaker-xgboost:1.0-1-cpu-py3 | ||
| imageConfig: | ||
| repositoryAccessMode: Platform | ||
| repositoryAuthConfig: {} |
There was a problem hiding this comment.
These same four lines are present in the created.yaml of this resource
| name: unit-testing-transform-job | ||
| spec: | ||
| dataProcessing: | ||
| inputFilter: $ |
There was a problem hiding this comment.
$?
Can we remove this $ and null fields?
There was a problem hiding this comment.
the $ comes from the custom_delta.go file for this resource
There was a problem hiding this comment.
looks like something related to response from service https://github.com/aws-controllers-k8s/sagemaker-controller/blob/main/pkg/resource/transform_job/testdata/sdkapi/describe/inprogress_describe.json#L6-L8
|
/retest sagemaker-unit-test |
|
@surajkota: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test sagemaker-unit-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaijal, ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
LateInitializetotest_suite_runner.goLateInitializeunit tests which invokeLateInitializeLateInitializeso there will be no difference in the latest resource.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.