Skip to content

Fix delta bug #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Fix delta bug #163

merged 1 commit into from
Aug 12, 2022

Conversation

ananth102
Copy link
Member

Issue #, if available:

If the user creates a training job with a profileRuleConfiguration but without a debugRuleConfiguration the controller crashes because it compares profileRuleConfiguration and debugRuleConfiguration(which could have a length of zero) and causes an index error.

Steps to reproduce:

Run trainingjob with normal parameters(https://github.com/aws-controllers-k8s/sagemaker-controller/blob/main/samples/training/my-training-job.yaml) but with a profileRuleConfiguration and profilerConfig

Description of changes:

Changes custom set defaults function to compare only profileRuleConfiguration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 12, 2022

Hi @ananth102. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ryansteakley
Copy link
Member

/ok-to-test

@ack-bot ack-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2022
@surajkota
Copy link
Member

/approve

@surajkota
Copy link
Member

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ananth102, ryansteakley, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ryansteakley,surajkota]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 521dba1 into aws-controllers-k8s:main Aug 12, 2022
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request Jan 19, 2024
Issue #, if available:

If the user creates a training job with a profileRuleConfiguration but without a debugRuleConfiguration the controller crashes because it compares profileRuleConfiguration and debugRuleConfiguration(which could have a length of zero) and causes an index error. 

Steps to reproduce:

Run trainingjob with normal parameters(https://github.com/aws-controllers-k8s/sagemaker-controller/blob/main/samples/training/my-training-job.yaml) but with a profileRuleConfiguration and profilerConfig 

Description of changes:

Changes custom set defaults function to compare only profileRuleConfiguration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants