-
Notifications
You must be signed in to change notification settings - Fork 36
Fix delta bug #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix delta bug #163
Conversation
Hi @ananth102. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ananth102, ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: If the user creates a training job with a profileRuleConfiguration but without a debugRuleConfiguration the controller crashes because it compares profileRuleConfiguration and debugRuleConfiguration(which could have a length of zero) and causes an index error. Steps to reproduce: Run trainingjob with normal parameters(https://github.com/aws-controllers-k8s/sagemaker-controller/blob/main/samples/training/my-training-job.yaml) but with a profileRuleConfiguration and profilerConfig Description of changes: Changes custom set defaults function to compare only profileRuleConfiguration. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available:
If the user creates a training job with a profileRuleConfiguration but without a debugRuleConfiguration the controller crashes because it compares profileRuleConfiguration and debugRuleConfiguration(which could have a length of zero) and causes an index error.
Steps to reproduce:
Run trainingjob with normal parameters(https://github.com/aws-controllers-k8s/sagemaker-controller/blob/main/samples/training/my-training-job.yaml) but with a profileRuleConfiguration and profilerConfig
Description of changes:
Changes custom set defaults function to compare only profileRuleConfiguration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.