Skip to content

release artifacts for release v0.4.1 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

ryansteakley
Copy link
Member

Release Notes Draft:
Fixes bug with training-job in which training job with a profileRuleConfiguration but without a debugRuleConfiguration the controller crashes.

  • Changes custom set defaults function to compare only profileRuleConfiguration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryansteakley, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ryansteakley,surajkota]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ryansteakley
Copy link
Member Author

/test sagemaker-unit-test

1 similar comment
@ryansteakley
Copy link
Member Author

/test sagemaker-unit-test

@a-hilaly
Copy link
Member

looks like it's a gIthub.com/gopkg.in hiccup
/retest

@ryansteakley
Copy link
Member Author

/test sagemaker-unit-test

@ack-bot ack-bot merged commit 1c67e4e into aws-controllers-k8s:main Aug 12, 2022
ryansteakley added a commit to ryansteakley/sagemaker-controller that referenced this pull request Jan 19, 2024
Release Notes Draft:
Fixes bug with training-job in which training job with a profileRuleConfiguration but without a debugRuleConfiguration the controller crashes.

- Changes custom set defaults function to compare only profileRuleConfiguration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants