Skip to content

Added migrate resources note to README #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

judyheflin
Copy link
Contributor

Added note on steps to migrate resources to the ACK controller if you're coming from the old SageMaker operators for Kubernetes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 2, 2022

Hi @judyheflin. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2022
Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, one minor comment

README.md Outdated

Sample:
Example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the following sample demonstrates how to adopt a SageMaker Endpoint

Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: judyheflin, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member

a-hilaly commented Sep 9, 2022

/retest

@ack-bot ack-bot merged commit 1bedb69 into aws-controllers-k8s:main Sep 9, 2022
akartsky pushed a commit to akartsky/ack-sagemaker-controller that referenced this pull request Sep 20, 2022
Added note on steps to migrate resources to the ACK controller if you're coming from the old SageMaker operators for Kubernetes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
akartsky pushed a commit to akartsky/ack-sagemaker-controller that referenced this pull request Sep 20, 2022
Added note on steps to migrate resources to the ACK controller if you're coming from the old SageMaker operators for Kubernetes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request Jan 19, 2024
Added note on steps to migrate resources to the ACK controller if you're coming from the old SageMaker operators for Kubernetes. 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants