Skip to content

Pipeline-Execution Unit Tests #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ryansteakley
Copy link
Member

Issue #, if available:

Description of changes:
Adds unit-tests for pipeline-execution resource
Also moves pipeline-execution to bottom of file in generator.yaml
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryansteakley ryansteakley changed the title unit-tests for pipeline-execution resource Pipeline-Execution Unit Tests Dec 7, 2022
@ryansteakley
Copy link
Member Author

/test sagemaker-unit-test

1 similar comment
@ryansteakley
Copy link
Member Author

/test sagemaker-unit-test

@ananth102
Copy link
Member

/approve assuming there isnt a way to test the adopted resource code

@ryansteakley
Copy link
Member Author

/approve assuming there isnt a way to test the adopted resource code

Don't know of a way to do that off top of my head. Will be something good to not down.

@ryansteakley
Copy link
Member Author

/lgtm

@ack-bot
Copy link
Collaborator

ack-bot commented Dec 8, 2022

@ryansteakley: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot
Copy link
Collaborator

ack-bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ananth102, ryansteakley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ryansteakley ryansteakley merged commit e7294af into aws-controllers-k8s:main Dec 8, 2022
ryansteakley added a commit to ryansteakley/sagemaker-controller that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants