Feature: Serverless Endpoint #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
requested changes
Jan 19, 2023
| "MemorySizeInMB": 1024 | ||
| }, | ||
| "VariantName": "AllTraffic", | ||
| "VolumeSizeInGB": 5 |
There was a problem hiding this comment.
hmm, lets try to also get answer from service team on why the behavior is like this? wouldnt it confuse the user
| if ackcompare.IsNotNil(a.ko.Spec.ProductionVariants) && ackcompare.IsNotNil(a.ko.Spec.ProductionVariants) { | ||
| if len(a.ko.Spec.ProductionVariants) == len(b.ko.Spec.ProductionVariants) { | ||
| for i, _ := range a.ko.Spec.ProductionVariants { | ||
| if a.ko.Spec.ProductionVariants[i].VolumeSizeInGB == nil && b.ko.Spec.ProductionVariants[i].VolumeSizeInGB != nil { |
There was a problem hiding this comment.
lets add another check here, do it only if variant.ServerlessConfig != nil?
nit: add a comment here for why we have custom code, since server side default doesn't handle slices
RedbackThomson
suggested changes
Jan 19, 2023
surajkota
approved these changes
Jan 20, 2023
| if ackcompare.IsNotNil(a.ko.Spec.ProductionVariants) && ackcompare.IsNotNil(a.ko.Spec.ProductionVariants) { | ||
| if len(a.ko.Spec.ProductionVariants) == len(b.ko.Spec.ProductionVariants) { | ||
| for i, _ := range a.ko.Spec.ProductionVariants { | ||
| if a.ko.Spec.ProductionVariants[i].ServerlessConfig != nil { |
There was a problem hiding this comment.
nit: this can be one if statement
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ananth102, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ryansteakley
pushed a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
Jan 19, 2024
Issue #, if available: Description of changes: This pull request contains code/unit tests for the Serverless Endpoint. Changes made: `generator.yaml` - Uncommenting shape and adding hook. `pkg/resource/endpoint_config/custom_delta.go` - Code that handles server side default. Late initialization isnt possible because this field is an array. `testdata/` - Unit tests The Server returns a value for VolumeSizeInGB despite it being a parameter the user cannot even specify while using a serverless endpoint. The same problem is not there for an instance based endpoint config. Manual testing (Will delete this before merge): Endpoint Config: [Serverless] Async Conifg - Validation Exception [Serverless] Multi Variant - Validation Exception [Serverless] Data Capture - Validation Exception [Serverless] Including VolumeSizeInGB in spec: Validation exception [Serverless] No VolumeSizeInGB: Normal reconciliation, no errors after restart. [Normal] No VolumeSizeInGB - Normal reconciliation, no errors after restart. [Normal] VolumeSizeInGB - Normal reconciliation, no errors after restart. Endpoint: Launching Serverless: Works, user sees information in PendingDeploymentSummary Updating Instance→ Serverless: Validation Exception Updating Serverless → Instance: Production variant must have a different name, works. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This pull request contains code/unit tests for the Serverless Endpoint.
Changes made:
generator.yaml- Uncommenting shape and adding hook.pkg/resource/endpoint_config/custom_delta.go- Code that handles server side default. Late initialization isnt possible because this field is an array.testdata/- Unit testsThe Server returns a value for VolumeSizeInGB despite it being a parameter the user cannot even specify while using a serverless endpoint. The same problem is not there for an instance based endpoint config.
Manual testing (Will delete this before merge):
Endpoint Config:
[Serverless] Async Conifg - Validation Exception
[Serverless] Multi Variant - Validation Exception
[Serverless] Data Capture - Validation Exception
[Serverless] Including VolumeSizeInGB in spec: Validation exception
[Serverless] No VolumeSizeInGB: Normal reconciliation, no errors after restart.
[Normal] No VolumeSizeInGB - Normal reconciliation, no errors after restart.
[Normal] VolumeSizeInGB - Normal reconciliation, no errors after restart.
Endpoint:
Launching Serverless: Works, user sees information in PendingDeploymentSummary
Updating Instance→ Serverless: Validation Exception
Updating Serverless → Instance: Production variant must have a different name, works.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.