Refactor e2e deletion and unmark adopted Endpoint Test #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
requested changes
Mar 18, 2023
surajkota
requested changes
Mar 20, 2023
test/e2e/__init__.py
Outdated
| deleted = True | ||
|
|
||
| if k8s.get_resource_exists(reference): | ||
| _, deleted = k8s.delete_custom_resource(reference, wait_period*2, wait_length) |
There was a problem hiding this comment.
nit: lets double the value of the constant or at the passing method to keep the method generic
lets use cfg.DELETE_WAIT_PERIOD, cfg.DELETE_WAIT_LENGTH for the ones with 3, 10? similar to job
surajkota
requested changes
Mar 21, 2023
test/e2e/tests/test_model_package.py
Outdated
| assert deleted | ||
|
|
||
|
|
||
| assert delete_custom_resource(reference, DELETE_WAIT_PERIOD, DELETE_WAIT_LENGTH) |
test/e2e/tests/test_model_package.py
Outdated
| ) | ||
| assert deleted | ||
|
|
||
| assert delete_custom_resource(reference, DELETE_WAIT_PERIOD, DELETE_WAIT_LENGTH) |
| assert deleted | ||
|
|
||
|
|
||
| assert delete_custom_resource(reference, DELETE_WAIT_PERIOD, DELETE_WAIT_LENGTH) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ryansteakley
added a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
Mar 21, 2023
…rs-k8s#216) Issue #, if available: Description of changes: Disabling the adopted endpoint test as canary since this does not provide value for a canary, will keep as e2e test. Refactors ``` if k8s.get_resource_exists(reference): _, deleted = k8s.delete_custom_resource(reference, cfg.JOB_DELETE_WAIT_PERIODS, cfg.JOB_DELETE_WAIT_LENGTH) > assert deleted ``` into a shared method, and adds a retry loop for this assert. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-prow bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
) (#219) Issue #, if available: Description of changes: Disabling the adopted endpoint test as canary since this does not provide value for a canary, will keep as e2e test. Refactors ``` if k8s.get_resource_exists(reference): _, deleted = k8s.delete_custom_resource(reference, cfg.JOB_DELETE_WAIT_PERIODS, cfg.JOB_DELETE_WAIT_LENGTH) > assert deleted ``` into a shared method, and adds a retry loop for this assert. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Issue #, if available: Description of changes: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ryansteakley
added a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
Jan 19, 2024
…rs-k8s#216) Issue #, if available: Description of changes: Disabling the adopted endpoint test as canary since this does not provide value for a canary, will keep as e2e test. Refactors ``` if k8s.get_resource_exists(reference): _, deleted = k8s.delete_custom_resource(reference, cfg.JOB_DELETE_WAIT_PERIODS, cfg.JOB_DELETE_WAIT_LENGTH) > assert deleted ``` into a shared method, and adds a retry loop for this assert. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Disabling the adopted endpoint test as canary since this does not provide value for a canary, will keep as e2e test. Refactors
into a shared method, and adds a retry loop for this assert.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.