Skip to content

Enable debug logging for canary #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

ryansteakley
Copy link
Member

@ryansteakley ryansteakley commented Mar 20, 2023

Issue #, if available:

Description of changes:
Temporarily enable these fields to allow for debugging
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryansteakley ryansteakley requested a review from surajkota as a code owner March 20, 2023 21:18
@ack-prow ack-prow bot requested a review from RedbackThomson March 20, 2023 21:18
@ack-prow ack-prow bot added the approved label Mar 20, 2023
@ryansteakley ryansteakley changed the base branch from main to release-v1.2.0 March 20, 2023 22:10
@ryansteakley ryansteakley changed the base branch from release-v1.2.0 to main March 20, 2023 22:13
@surajkota
Copy link
Member

/approve
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryansteakley, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ryansteakley,surajkota]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit dadad08 into aws-controllers-k8s:main Mar 20, 2023
ryansteakley added a commit to ryansteakley/sagemaker-controller that referenced this pull request Mar 21, 2023
Issue #, if available:

Description of changes:
Temporarily enable these fields to allow for debugging
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-prow bot pushed a commit that referenced this pull request Mar 21, 2023
Issue #, if available:

Description of changes:
Temporarily enable these fields to allow for debugging By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ryansteakley added a commit to ryansteakley/sagemaker-controller that referenced this pull request Jan 19, 2024
Issue #, if available:

Description of changes:
Temporarily enable these fields to allow for debugging
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants