Skip to content

Increase wait period in test for sagemaker resource #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

jsitu777
Copy link
Contributor

Increase wait perior to fix the error that some sagemaker resources are not ready

        model_reference, model_spec, model_resource = create_sagemaker_resource(
            resource_plural=cfg.MODEL_RESOURCE_PLURAL,
            resource_name=model_resource_name,
            spec_file="xgboost_model_with_model_location",
            replacements=replacements,
        )
>       assert model_resource is not None
E       AssertionError

@ack-prow ack-prow bot requested a review from a-hilaly March 27, 2023 20:35
@ack-prow ack-prow bot added the approved label Mar 27, 2023
@ananth102
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ananth102, jsitu777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsitu777 jsitu777 merged commit 9f244ac into aws-controllers-k8s:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants