Add select_regions_1 as config and unindent pytest command #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ryansteakley
added a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
Mar 31, 2023
…ollers-k8s#230) Issue #, if available: Description of changes: Later refactor to this code, had incorrect indent which causes tests to not run when the ifstatement is true. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ryansteakley
added a commit
that referenced
this pull request
Mar 31, 2023
Issue #, if available: Description of changes: Later refactor to this code, had incorrect indent which causes tests to not run when the ifstatement is true. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ryansteakley
added a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
Jan 19, 2024
…ollers-k8s#230) Issue #, if available: Description of changes: Later refactor to this code, had incorrect indent which causes tests to not run when the ifstatement is true. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Later refactor to this code, had incorrect indent which causes tests to not run when the ifstatement is true.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.