Skip to content

Add dummy values in replacement_values.py #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

rd-pong
Copy link
Contributor

@rd-pong rd-pong commented Apr 19, 2023

Issue #, if available:

Description of changes:
Add dummy values in replacement_values.py to avoid KeyError (when collecting tests)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from jljaco April 19, 2023 02:30
@ack-prow ack-prow bot added the approved label Apr 19, 2023
@rd-pong
Copy link
Contributor Author

rd-pong commented Apr 19, 2023

/test sagemaker-kind-e2e

Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

we can look at how to change the replacement_value implementation later so we dont need to do this for every new region

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@ack-prow
Copy link

ack-prow bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rd-pong, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit be0096d into aws-controllers-k8s:main Apr 19, 2023
@rd-pong rd-pong deleted the dummy-replacement-value branch April 19, 2023 16:46
rd-pong added a commit that referenced this pull request Apr 19, 2023
Issue #, if available:

Description of changes:
Add dummy values in replacement_values.py to avoid KeyError (when collecting tests)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants