Skip to content

cherry pick: modify canary to use shallow from env (#246) #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

ananth102
Copy link
Member

Issue #, if available: n/a

Description of changes:

  • Modifying the run_test script to add the shallow marker based off an environment variable rather than having it in the script

Testing

  • Tested inside one of the canaries

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue #, if available: n/a

Description of changes:

- Modifying the run_test script to add the shallow marker based off an
environment variable rather than having it in the script

Testing

- Tested inside one of the canaries 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@ack-prow ack-prow bot requested a review from jsitu777 August 28, 2023 23:39
@ack-prow ack-prow bot added the approved label Aug 28, 2023
@ack-prow
Copy link

ack-prow bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ananth102, ryansteakley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ananth102,ryansteakley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ananth102 ananth102 merged commit c79d5db into release-v1.2.2 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants