Add OWNERS templates #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
reviewed
May 14, 2021
| - RedbackThomson | ||
| - vijtrip2 | ||
| # TODO: Add your team members to your team controller alias | ||
| service-team: [] |
There was a problem hiding this comment.
can you add the aliases from here?
https://github.com/aws-controllers-k8s/sagemaker-controller/blob/main/CODEOWNERS
surajkota
approved these changes
May 14, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RedbackThomson, surajkota The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ryansteakley
pushed a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
May 17, 2021
ryansteakley
pushed a commit
to ryansteakley/sagemaker-controller
that referenced
this pull request
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the OWNERS and OWNERS_ALIASES template files. Service teams still need to add their particular GitHub aliases in the OWNERS_ALIASES group.