Feature group sample #46
Conversation
|
Hi @BriannaRoskind. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-bot
added
the
needs-ok-to-test
|
/approve cancel |
BriannaRoskind
force-pushed
the
feature_group_sample
branch
from
9b6ac3f to
e8db6ba
Compare
Changed data ingestion sample code format. Also Removed typo.
BriannaRoskind
force-pushed
the
feature_group_sample
branch
from
042bdf7 to
ca4cb03
Compare
samples/feature_group/README.md
Outdated
| service_name="sagemaker-featurestore-runtime") | ||
|
|
||
| ### OPTION 1: To Download all records at once and upload records sequentially | ||
| records = [] |
There was a problem hiding this comment.
use the faster run option & make it a script instead of the readme. add the commands here to run it. Take file location as an input
create a file for csv file as well since its pretty small
| @@ -0,0 +1,108 @@ | |||
| # Feature Group Sample | |||
|
|
|||
| This sample demonstrates how to create a feature group using the Amazon AWS Controllers for Kubernetes (ACK) service controller for Amazon SageMaker. | |||
There was a problem hiding this comment.
If this is taken from a notebook, can you please add a reference/link to it?
It'll be useful for us as well. We need to start doing it for all samples
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akartsky, BriannaRoskind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/approve |
Added a feature group sample subdirectory, README, and sample code.
This PR assumes feature group testing code from PR #50, is already in place.